Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Java parser command line interface #1164

Merged
merged 2 commits into from
Nov 11, 2019
Merged

Add Java parser command line interface #1164

merged 2 commits into from
Nov 11, 2019

Conversation

tonyyang-svail
Copy link
Collaborator

@tonyyang-svail tonyyang-svail commented Nov 9, 2019 •
edited
Loading

Part of #1126.

Yancey1989
Yancey1989 approved these changes Nov 10, 2019
View reviewed changes
Copy link
Collaborator

@Yancey1989 Yancey1989 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with tiny comment.

java/parser/src/test/java/org/sqlflow/parser/ParserAdaptorTest.java
public void testCmd() {
try {
// FIXME(tony): create file in a temporary directory
FileUtils.writeByteArrayToFile(new File("test.sql"), "select 1".getBytes());
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can use createTempFile to create the temporary file.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I will try it out in future PRs.

@tonyyang-svail tonyyang-svail merged commit cef57c9 into sql-machine-learning:develop Nov 11, 2019
@tonyyang-svail tonyyang-svail deleted the add_java_cmd branch November 11, 2019 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yancey1989 Yancey1989 Yancey1989 approved these changes

@typhoonzero typhoonzero Awaiting requested review from typhoonzero

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tonyyang-svail @Yancey1989