Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated API from WebContentGenerator #31492

Closed
bclozel opened this issue Oct 25, 2023 · 2 comments
Closed

Remove deprecated API from WebContentGenerator #31492

bclozel opened this issue Oct 25, 2023 · 2 comments
Assignees
Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) type: task A general task
Milestone

Comments

@bclozel
Copy link
Member

bclozel commented Oct 25, 2023

Some API in WebContentGenerator was deprecated back in 4.2 and we should remove this support now. HTTP 1.0 is not supported anymore, the CacheControl configuration variant is much superior and the HTTP caching defaults are more in line with best practices.

@bclozel bclozel added in: web Issues in web modules (web, webmvc, webflux, websocket) type: task A general task labels Oct 25, 2023
@bclozel bclozel added this to the 6.1.0-RC2 milestone Oct 25, 2023
@bclozel bclozel self-assigned this Oct 25, 2023
@bclozel bclozel modified the milestones: 6.1.0-RC2, 6.2.x Oct 25, 2023
@prakhar2451
Copy link

I've come across some deprecated APIs in the codebase in context of this issue. I wanted to seek your guidance on how you would like contributions related to these deprecated APIs to be handled. Specifically, I'm wondering if the intention is to simply remove the deprecated APIs, or if there is a preference to migrate to the CacheControl configuration.

bclozel added a commit to bclozel/spring-framework that referenced this issue Oct 30, 2023
@bclozel
Copy link
Member Author

bclozel commented Oct 30, 2023

@prakhar2451 thanks for the proposal, but the changes are all ready here: https://github.com/bclozel/spring-framework/tree/gh-31492

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) type: task A general task
Projects
None yet
Development

No branches or pull requests

3 participants