Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove additional APIs deprecated for removal in 6.1 #30604

Closed
3 of 14 tasks
sbrannen opened this issue Jun 6, 2023 · 6 comments
Closed
3 of 14 tasks

Remove additional APIs deprecated for removal in 6.1 #30604

sbrannen opened this issue Jun 6, 2023 · 6 comments
Assignees
Labels
type: task A general task
Milestone

Comments

@sbrannen
Copy link
Member

sbrannen commented Jun 6, 2023

Overview

This is a follow up to gh-29449.

Candidates

  • org.springframework.scheduling.support.CronSequenceGenerator
  • org.springframework.http.codec.multipart.DefaultPartHttpMessageReader.setStreaming(boolean)
  • org.springframework.http.server.reactive.AbstractServerHttpRequest

For Removal in 6.2

See #30608

  • org.springframework.util.Base64Utils was only marked for removal in a 6.0.x maintenance release, to be removed in 6.2.
  • org.springframework.http.client.AbstractClientHttpResponse was only marked for removal in 6.1, though deprecated in 6.0.
  • org.springframework.http.client.ClientHttpResponse.getRawStatusCode() was only marked for removal in 6.1, though deprecated in 6.0.
  • org.springframework.http.client.observation.ClientHttpObservationDocumentation.HighCardinalityKeyNames.CLIENT_NAME was only marked for removal in a 6.0.x maintenance release, to be removed in 6.2
  • org.springframework.web.reactive.function.client.ClientHttpObservationDocumentation.HighCardinalityKeyNames.CLIENT_NAME was only marked for removal in a 6.0.x maintenance release, to be removed in 6.2
  • org.springframework.web.filter.reactive.ServerWebExchangeContextFilter.get(Context)
  • org.springframework.web.servlet.mvc.method.annotation.ResponseEntityExceptionHandler.handleBindException(BindException, HttpHeaders, HttpStatusCode, WebRequest)
  • org.springframework.web.servlet.mvc.support.DefaultHandlerExceptionResolver.handleBindException(BindException, HttpServletRequest, HttpServletResponse, Object)
  • org.springframework.web.reactive.HandlerResult
  • org.springframework.web.reactive.socket.client.JettyWebSocketClient
  • org.springframework.web.socket.client.jetty.JettyWebSocketClient
@sbrannen sbrannen added the type: task A general task label Jun 6, 2023
@sbrannen sbrannen added this to the 6.1.0-M1 milestone Jun 6, 2023
poutsma added a commit that referenced this issue Jun 7, 2023
@poutsma
Copy link
Contributor

poutsma commented Jun 7, 2023

I have removed the APIs that I marked for removal.

Note that AbstractClientHttpResponse and ClientHttpResponse.getRawStatusCode() were only marked for removal in 6.1—though deprecated in 6.0, so I think we should wait with removing those until 6.2.

@sbrannen
Copy link
Member Author

@rstoyanchev, it appears that the remaining items fall under your area of expertise, so I've assigned this issue to you.

@rstoyanchev
Copy link
Contributor

The remaining ones are relatively recent deprecations, 6.0.6 for ServerWebExchangeContextFilter, 6.0.7 for ResponseEntityExceptionHandler and DefaultHandlerExceptionResolver, and 6.0 for HandlerResult and the JettyWebSocketClient implementations. I think they can wait until 6.2.

@sbrannen sbrannen assigned poutsma and unassigned rstoyanchev Jun 14, 2023
mdeinum pushed a commit to mdeinum/spring-framework that referenced this issue Jun 29, 2023
@hantsy
Copy link
Contributor

hantsy commented Jul 20, 2023

What is the replacement of CronSequenceGenerator?

@poutsma
Copy link
Contributor

poutsma commented Jul 20, 2023

What is the replacement of CronSequenceGenerator?

It says so right in the Javadoc

@hantsy
Copy link
Contributor

hantsy commented Jul 20, 2023

What is the replacement of CronSequenceGenerator?

It says so right in the Javadoc

Thanks.
Try to update my sample and found it is missing in the imports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: task A general task
Projects
None yet
Development

No branches or pull requests

4 participants