[FLINK-16178][refactor] Remove redundant (duplicate) check on version…

… availability.
spotify · Feb 25, 2020 · ca626cd · ca626cd
1 parent 4ae98ff
commit ca626cd
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 8 deletions.
diff --git a/flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/Checkpoints.java b/flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/Checkpoints.java
@@ -104,13 +104,7 @@ public static Savepoint loadCheckpointMetadata(DataInputStream in, ClassLoader c
  if (magicNumber == HEADER_MAGIC_NUMBER) {
  final int version = in.readInt();
  final SavepointSerializer<?> serializer = SavepointSerializers.getSerializer(version);
-
- if (serializer != null) {
- return serializer.deserialize(in, classLoader);
- }
- else {
- throw new IOException("Unrecognized checkpoint version number: " + version);
- }
+ return serializer.deserialize(in, classLoader);
  }
  else {
  throw new IOException("Unexpected magic number. This can have multiple reasons: " +

diff --git a/...ime/src/main/java/org/apache/flink/runtime/checkpoint/savepoint/SavepointSerializers.java b/...ime/src/main/java/org/apache/flink/runtime/checkpoint/savepoint/SavepointSerializers.java
@@ -76,7 +76,7 @@ public static SavepointSerializer<?> getSerializer(int version) {
  if (serializer != null) {
  return serializer;
  } else {
- throw new IllegalArgumentException("Cannot restore savepoint version " + version + ".");
+ throw new IllegalArgumentException("Unrecognized checkpoint version number: " + version);
  }
  }