Skip to content

Commit

Permalink
[FLINK-10906][docker] Don't print configuration in docker-entrypoint.sh
Browse files Browse the repository at this point in the history
In order to not leak secrets we should not print the configuration in docker-entrypoint.sh.
  • Loading branch information
tillrohrmann committed Nov 17, 2018
1 parent aabbd65 commit 3609f36
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 3 deletions.
1 change: 0 additions & 1 deletion flink-container/docker/docker-entrypoint.sh
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,6 @@ if [ "${CMD}" == "--help" -o "${CMD}" == "-h" ]; then
exit 0
elif [ "${CMD}" == "${JOB_CLUSTER}" -o "${CMD}" == "${TASK_MANAGER}" ]; then
echo "Starting the ${CMD}"
echo "config file: " && grep '^[^\n#]' $FLINK_HOME/conf/flink-conf.yaml

if [ "${CMD}" == "${TASK_MANAGER}" ]; then
exec $FLINK_HOME/bin/taskmanager.sh start-foreground "$@"
Expand Down
2 changes: 0 additions & 2 deletions flink-contrib/docker-flink/docker-entrypoint.sh
Original file line number Diff line number Diff line change
Expand Up @@ -29,15 +29,13 @@ elif [ "$1" == "jobmanager" ]; then
echo "Starting Job Manager"
sed -i -e "s/jobmanager.rpc.address: localhost/jobmanager.rpc.address: ${JOB_MANAGER_RPC_ADDRESS}/g" $FLINK_HOME/conf/flink-conf.yaml

echo "config file: " && grep '^[^\n#]' $FLINK_HOME/conf/flink-conf.yaml
exec $FLINK_HOME/bin/jobmanager.sh start-foreground
elif [ "$1" == "taskmanager" ]; then

sed -i -e "s/jobmanager.rpc.address: localhost/jobmanager.rpc.address: ${JOB_MANAGER_RPC_ADDRESS}/g" $FLINK_HOME/conf/flink-conf.yaml
sed -i -e "s/taskmanager.numberOfTaskSlots: 1/taskmanager.numberOfTaskSlots: $(grep -c ^processor /proc/cpuinfo)/g" $FLINK_HOME/conf/flink-conf.yaml

echo "Starting Task Manager"
echo "config file: " && grep '^[^\n#]' $FLINK_HOME/conf/flink-conf.yaml
exec $FLINK_HOME/bin/taskmanager.sh start-foreground
fi

Expand Down

0 comments on commit 3609f36

Please sign in to comment.