improved songs searching

[xnetcat]

Instead of searching only for videos in YouTube music, search for everything but get only videos and songs. We can't specify more than 1 filter when retrieving data from YouTube api.

Another solution would be to concat two lists (songs, videos) but that would increase number of requests because we have to send 2 POST requests to yt api instead of one. This would increase the chance of getting rate limited

searchSongs = ytmApiClient.search(searchTerm, filter='songs')
searchVideos = ytmApiClient.search(searchTerm, filter='videos')
searchResult = searchSongs + searchVideos

[xnetcat]

I will have to update tests. Tests with real network connection work just fine tho

[aklajnert]

The code looks good, but please fix the CI checks.

[xnetcat]

The code looks good, but please fix the CI checks.

Regression test are failing because of ffmpeg (fixed in #1200).

[xnetcat]

And I have no clue why flake8 fails, it completes successfully on my pc

[aklajnert]

Huh, interesting - the versions seem to be the same. What happens if you fix the error from the CI? Will it fail locally?

[xnetcat]

Huh, interesting - the versions seem to be the same. What happens if you fix the error from the CI? Will it fail locally?

Yup, it failed

[xnetcat]

It's funny because I didn't even change this file.

[aklajnert]

Can you run tox --recreate -e flake8? Does that change anything?

[xnetcat]

Can you run tox --recreate -e flake8? Does that change anything?

Nope

[aklajnert]

In this case, I would add ignore = E301 to [flake8] section in setup.cfg. There's no point in fighting with the linter if it goes wild. This particular error is not very important anyway.

[aklajnert]

I guess the #1200 should be merged first. The flake8 error there seems reasonable, regardless that the file wasn't changed.

[xnetcat]

Can you approve changes in #1200

[fizzy123]

Just wanted to say, very excited for this! I just made this change locally and it makes things so much better!

[Silverarmor]

@xnetcat please update branch & resolve conflicts.

[xnetcat]

@Silverarmor resolved conflicts