Refactor spotify client #1188
Merged
Refactor spotify client #1188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9c54918
to
e5cf128
Compare
xnetcat
requested changes
Feb 22, 2021
e5cf128
to
fe65a2c
Compare
ghost
approved these changes
Mar 21, 2021
xnetcat
approved these changes
Mar 21, 2021
|
LGTM! |
Merged
Silverarmor
added a commit
that referenced
this pull request
Mar 26, 2021
* Fix MikhailZex GitHub's link (#1215) Authored by @jcs090218 * Use the proper name for beautifulsoup4 (#1210) Authored by @timschumi * Refactor spotify client (#1188) Authored by @aklajnert * Switch to rich (#1098) Authored by @phcreery * Bump version number to 3.5.0 Co-authored-by: Jen-Chieh Shen <[email protected]> Co-authored-by: Tim Schumacher <[email protected]> Co-authored-by: Andrzej Klajnert <[email protected]> Co-authored-by: Peyton Creery <[email protected]> Co-authored-by: Michael George <[email protected]> Co-authored-by: Jakub <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the global variables to a more object-oriented approach. Now the
Spotifyclient can be easily extended if necessary.