Allow specifying output directory

[aklajnert]

This is a very small change that'll allow specifying the output directory by specifying -o or --output argument.
Some users were asking for it, and I find it also useful to me.

[phcreery]

I really like this option. My question, why chdir and not modify convertedFilePath of `downloader.py'? I feel like the latter is more explicit and easier to understand.

[aklajnert]

I really like this option. My question, why chdir and not modify convertedFilePath of `downloader.py'? I feel like the latter is more explicit and easier to understand.

It would complicate the code too much in my opinion. Simply changing the working directory is very easy and works just fine.

[bee395]

I tested it on Linux and it works fine.

When I specify a folder without permission, I get a PermissionError with traceback, but since it's short and clear to understand what went wrong, I think it's not a problem

Would it be possible to create a folder, if the folder does not yet exists?

[xnetcat]

Would it be possible to create a folder, if the folder does not yet exist?

Yeah like that

if not os.path.isdir(arguments.path):
    os.makedirs(arguments.path)
    print("Created download folder")

[xnetcat]

Also, maybe we should come back to the starting path after finishing the download

[aklajnert]

When I specify a folder without permission, I get a PermissionError with traceback, but since it's short and clear to understand what went wrong, I think it's not a problem

Good to know, I'll see what I can do there.

Would it be possible to create a folder, if the folder does not yet exists?

I think it would make sense. Not sure, however, if we should accept any path and use mkdir -p equivalent to potentially create multiple levels, or create only one level and raise an error if there is a need to create more. The first option could make some mess if a user forgets a slash in the beginning.

Also, maybe we should come back to the starting path after finishing the download

I don't see a reason to do that. The chdir() doesn't change workdir for the shell where the process was executed.

[xnetcat]

I don't see a reason to do that. The chdir() doesn't change workdir for the shell where the process was executed.

Oh ok my bad

[Silverarmor]

When I specify a folder without permission, I get a PermissionError with traceback, but since it's short and clear to understand what went wrong, I think it's not a problem

Good to know, I'll see what I can do there.

@aklajnert Do you want to do anything or is this ready to merge?

[aklajnert]

@Silverarmor - I'm considering @xnetcat suggestion about creating the output directory if it doesn't exist. I'm not really sure if that's a good idea at all, and if I should create multiple nested directories or limit to one only.

[Silverarmor]

@aklajnert think we can sneak this into v3.4.0 ?

[aklajnert]

@Silverarmor - Yeah, I guess we can merge it as is, we'll change the output directory behavior in case of feedback,

[Silverarmor]

@aklajnert @MikhailZex what happened to these changes 🤔