Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix windows bind/UDS regressions #819

Merged
merged 8 commits into from
Apr 25, 2024
Merged

Fix windows bind/UDS regressions #819

merged 8 commits into from
Apr 25, 2024

Conversation

jmeixensperger
Copy link
Contributor

@jmeixensperger jmeixensperger commented Apr 18, 2024 •
edited
Loading

@jmeixensperger jmeixensperger requested a review from a team as a code owner April 18, 2024 16:15
ruomeiy-splunk
ruomeiy-splunk previously approved these changes Apr 18, 2024
View reviewed changes
@jmeixensperger jmeixensperger changed the title Fix windows bind on 0.0.0.0 Fix windows bind/UDS regressions Apr 19, 2024
@jmeixensperger
Copy link
Contributor Author

Local tests are passing with 9.0.9 and 9.3.0, ready for review

@atoulme atoulme mentioned this pull request Apr 20, 2024
Merged
@jmeixensperger
Copy link
Contributor Author

@hendolim I verified that windows 9.3.0 has mgmtHostPort = 127.0.0.1:8089 as the /default/web.conf value, so we'll need that separate play for windows / 127.0.0.1

@jmeixensperger jmeixensperger merged commit 3fabc24 into develop Apr 25, 2024
codeboten pushed a commit to open-telemetry/opentelemetry-collector-contrib that referenced this pull request May 1, 2024
@atoulme
[chore] Fix Splunk integration test by simplifying the run and using …
e6fd2f9 
…an older Splunk build (#32575)

**Description:**
Use splunk.yaml to run the container and set it up at once.
Use 9.1.2 as latest version is affected by
splunk/splunk-ansible#819.

**Link to tracking Issue:**
Fixes #32534
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hendolim hendolim hendolim approved these changes

@ruomeiy-splunk ruomeiy-splunk ruomeiy-splunk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jmeixensperger @hendolim @ruomeiy-splunk