Switch uses of __import__ to importlib.get_module() #6653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## 2.0 #6653 +/- ##
==========================================
+ Coverage 83.75% 83.76% +0.01%
==========================================
Files 266 266
Lines 40893 40894 +1
Branches 5996 5995 -1
==========================================
+ Hits 34250 34255 +5
+ Misses 5320 5317 -3
+ Partials 1323 1322 -1
Continue to review full report at Codecov.
|
tk0miya
requested changes
Aug 17, 2019
The Python docs for __import__ recommend using importlib.get_module(). https://docs.python.org/3/library/functions.html#__import__ > Note: This is an advanced function that is not needed in everyday > Python programming, unlike importlib.import_module(). As importlib.get_module() uses the Python module cache and returns the module, this also allows simplifying many module cache checks of use of sys.modules. importlib.get_module() has been available since Python 3.3.
|
Sure thing. Rebased. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Python docs for
__import__recommend usingimportlib.get_module().https://docs.python.org/3/library/functions.html#__import__
As
importlib.get_module()uses the Python module cache and returns the module, this also allows simplifying many module cache checks of use ofsys.modules.importlib.get_module()has been available since Python 3.3.