Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update npm packages #6577

Merged
merged 1 commit into from
Jul 13, 2019
Merged

Update npm packages #6577

merged 1 commit into from
Jul 13, 2019

Conversation

tk0miya
Copy link
Member

@tk0miya tk0miya commented Jul 13, 2019

Feature or Bugfix

  • Security fix

Purpose

@tk0miya tk0miya added this to the 2.2.0 milestone Jul 13, 2019
@tk0miya tk0miya requested a review from TimKam July 13, 2019 11:04
@tk0miya tk0miya changed the base branch from master to 2.0 July 13, 2019 11:04
@codecov
Copy link

codecov bot commented Jul 13, 2019

Codecov Report

Merging #6577 into 2.0 will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##              2.0    #6577      +/-   ##
==========================================
- Coverage   83.78%   83.76%   -0.03%     
==========================================
  Files         266      268       +2     
  Lines       40829    40863      +34     
  Branches     5983     5986       +3     
==========================================
+ Hits        34210    34227      +17     
- Misses       5296     5310      +14     
- Partials     1323     1326       +3
Impacted Files Coverage Δ
sphinx/__init__.py 73.91% <0%> (ø)
sphinx/make_mode.py 0% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9a552a9...fb61bef. Read the comment docs.

@TimKam
Copy link
Member

TimKam commented Jul 13, 2019

@tk0miya LGTM; just noticed that the PR is targeted at 2.0 but the text says it will go into master. Hence, I do not merge myself.

@tk0miya
Copy link
Member Author

tk0miya commented Jul 13, 2019

Thank you for comment :-)

just noticed that the PR is targeted at 2.0 but the text says it will go into master. Hence, I do not merge myself.

Ah, sorry. I meant this will be merged into 2.0, but it will be also merged into master branch manually.

@tk0miya tk0miya merged commit 8b34e43 into 2.0 Jul 13, 2019
@tk0miya tk0miya deleted the npm_updates branch July 13, 2019 16:13
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants