Shrink the mypy whitelist: sphinx.application
#12568
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f63b4dc
to
6954d77
Compare
|
error in the docs build: looks a little like this one - #12286 |
AA-Turner
approved these changes
Jul 15, 2024
sphinx/application.py
Outdated
| assert issubclass(cls, SearchLanguage) | ||
| languages[cls.lang] = cls | ||
| from sphinx.search import languages | ||
| lang = cast(str, cls.lang) # SearchLanguage subclasses must set 'lang' to a str |
There was a problem hiding this comment.
I had thought that cast is meant to be avoided?
Suggested change
| lang = cast(str, cls.lang) # SearchLanguage subclasses must set 'lang' to a str | |
| lang = cls.lang | |
| assert isinstance(lang, str) # SearchLanguage subclasses must set 'lang' to a str |
sphinx.application
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
just chipping away at the mypy whitelist