add some comments for Union types [part 2b] #12281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 15, 2024
|
@AA-Turner Ah, I see what you did. Actually, I'd prefer keeping |
…yping-union-bugfix # Conflicts: # sphinx/util/typing.py # tests/test_util/test_util_typing.py
|
I'll go with your changes, so either we push this one just after #12280 just to add some comments for the future or we can skip this PR. |
…gfix # Conflicts: # sphinx/ext/autodoc/mock.py
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Union types were incorrectly rendered when
Noneis not the type in the list. LiteralNones are kept as is since they are semantically different (at least for me).Nevertheless, PEP 585 generics retain their ordering since this is also the case natively (i.e.,
None | intis rendered asNone | int).This is built upon #12280.