[search] JavaScript refactor: extract subcomponents from Search.query function. #12229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jayaddison
added
html search
internals:refactoring
javascript
picnixz
reviewed
Apr 4, 2024
…ble to 'searchParameters'.
picnixz
approved these changes
Apr 4, 2024
|
Thank you! |
|
Thank you! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature or Bugfix
Purpose
searchtools.jscode to make it more unit-testable.Detail
Search.querymethod intertwines display-related logic with search-related logic. In particular during unit testing, we want to test the latter without needing to mock out / stub the former -- so this changeset extracts subcomponents fromquerythat can be unit-tested individually.Relates
searchindex.jsfixtures in our JavaScript testing).