Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cleanup] test utils: more concise BaseHTTPRequestHandler references. #12158

Merged
merged 1 commit into from
Mar 21, 2024
Merged

[cleanup] test utils: more concise BaseHTTPRequestHandler references. #12158

merged 1 commit into from
Mar 21, 2024

Conversation

jayaddison
Copy link
Contributor

Feature or Bugfix

  • Refactoring

Purpose

  • Opportunistic cleanup.

Detail

  • Instead of importing the entire http.server module, select only the required BaseHTTPServer, and then refer to that by the shorter, locally-imported name.

Relates

chrisjsewell
chrisjsewell approved these changes Mar 21, 2024
View reviewed changes
Copy link
Member

@chrisjsewell chrisjsewell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okie, but the next priority is #2159 😏

@chrisjsewell chrisjsewell changed the title [refactor / cleanup] test utils: more concise BaseHTTPRequestHandler references. [cleanup] test utils: more concise BaseHTTPRequestHandler references. Mar 21, 2024
@chrisjsewell chrisjsewell merged commit d7c94d1 into sphinx-doc:master Mar 21, 2024
22 checks passed
@chrisjsewell
Copy link
Member

yep this commit failed the CI: https://github.com/sphinx-doc/sphinx/actions/runs/8376347449/job/22935843069

@jayaddison jayaddison deleted the refactor/testutils-more-concise-basehttpserver branch March 21, 2024 14:41
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 21, 2024
@AA-Turner AA-Turner added this to the 7.3.0 milestone Jul 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@chrisjsewell chrisjsewell chrisjsewell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
7.3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@jayaddison @chrisjsewell @AA-Turner