👌 Make ExtensionMetadata type public and use it in internal extensions
#12153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I really don't see the rationale for this being private; I feel it would be very good practice to encourage extensions to use it, and thus make it more likely for them to provide the correct metadata.
danieleades
approved these changes
Mar 21, 2024
picnixz
requested changes
Mar 21, 2024
The rationale was probably because we did not document it when we introduced it at first. |
Co-authored-by: Bénédikt Tran <[email protected]>
fair, well now that is all done 😄 |
picnixz
approved these changes
Mar 21, 2024
Co-authored-by: Bénédikt Tran <[email protected]>
ExtensionMetadata typed dict public and use it in internal extensionsExtensionMetadata type public and use it in internal extensions
chrisjsewell
commented
Mar 21, 2024
|
just let me know when this is released and i can start using it! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This type alias has now been fully documented for public consumption.
This will be beneficial to the sphinx ecosystem,
to aide/encourage extension developers to provide the correct metadata.