Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests] utils: refactor type-hint signatures. #12144

Merged
merged 7 commits into from
Mar 20, 2024
Merged

[tests] utils: refactor type-hint signatures. #12144

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
3038d75
[refactor] Begin reworking the tests.utils HTTP test server interface.
jayaddison Mar 19, 2024
3c89357
[tests] utils: refactor type-hint signatures.
jayaddison Mar 19, 2024
643cfb0
[tests] utils: make http_server 'tls_enabled' parameter keyword-only.
jayaddison Mar 20, 2024
31d79df
[tests] utils: move module-level attribute below __future__ import, b…
jayaddison Mar 20, 2024
4498a4a
[codestyle] test utils: fixup: single line both before-and-after modu…
jayaddison Mar 20, 2024
0cbadaa
[tests] use a tuple type for the utils module __all__ module declarat…
jayaddison Mar 20, 2024
82f612e
Merge branch 'master' into refactor/test-utils-http-server-signatures
jayaddison Mar 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
[tests] utils: make http_server 'tls_enabled' parameter keyword-only. 
Co-authored-by: Bénédikt Tran <[email protected]>
  • Loading branch information
@jayaddison @picnixz
jayaddison and picnixz committed Mar 20, 2024
commit 643cfb0fb111db45b3b640fc5b3a6ae7d02b4cf9
2 changes: 1 addition & 1 deletion tests/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ def __init__(


@contextmanager
def http_server(handler: type[BaseRequestHandler], tls_enabled: bool = False) -> Iterator[HttpServerThread]:
def http_server(handler: type[BaseRequestHandler], *, tls_enabled: bool = False) -> Iterator[HttpServerThread]:
server_cls = HttpsServerThread if tls_enabled else HttpServerThread
with filelock.FileLock(LOCK_PATH):
server = server_cls(handler, daemon=True)
Expand Down
Loading