Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ruff simplify config #12086

Merged
merged 7 commits into from
Mar 14, 2024
Merged

Conversation

danieleades
Copy link
Contributor

simplify ruff config

@danieleades danieleades mentioned this pull request Mar 14, 2024
5 tasks
@picnixz
Copy link
Member

picnixz commented Mar 14, 2024

Should I understand that, in the future, if ruff introduces new rules, they will be enabled but if any of them introduce an error, the dependabot will say "hey I cannot upgrade to that ruff"?

@danieleades
Copy link
Contributor Author

Should I understand that, in the future, if ruff introduces new rules, they will be enabled but if any of them introduce an error, the dependabot will say "hey I cannot upgrade to that ruff"?

If a ruff update introduces new lints that result in new errors, that will cause the CI jobs to fail on the dependabot PR. That's a signal that manual changes are needed before ruff can be updated

@picnixz
Copy link
Member

picnixz commented Mar 14, 2024

Thank you! I should have waited for my other PR in case the new ruff config introduced errors...

@picnixz picnixz merged commit 23dd754 into sphinx-doc:master Mar 14, 2024
7 checks passed
@danieleades danieleades deleted the ruff-simplify-config branch March 14, 2024 11:34
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 14, 2024
@AA-Turner AA-Turner added this to the 7.3.0 milestone Jul 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants