Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update mypy CI job to use local config #12013

Merged
merged 2 commits into from
Feb 26, 2024

Conversation

danieleades
Copy link
Contributor

@danieleades danieleades commented Feb 26, 2024

the mypy CI job currently installs its dependencies independently of the pyproject.toml file. This PR updates this so that the same dependencies are used for both local dev and in CI

see #12012 (comment)

@picnixz
Copy link
Member

picnixz commented Feb 26, 2024

Ah so that's also the reason why my mypy checks fail in #11972?

pyproject.toml Outdated Show resolved Hide resolved
Co-authored-by: Bénédikt Tran <[email protected]>
@danieleades
Copy link
Contributor Author

danieleades commented Feb 26, 2024

Ah so that's also the reason why my mypy checks fail in #11972?

yeah at the moment mypy isn't run on the tests/ directory at all in CI

see #12014

@picnixz picnixz merged commit d6f38ad into sphinx-doc:master Feb 26, 2024
7 checks passed
@danieleades danieleades deleted the mypy-config branch February 26, 2024 11:19
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 28, 2024
@AA-Turner AA-Turner added this to the 7.3.0 milestone Jul 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants