Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PyCode "Unparse": Added support for slice objects in subscriptions #11981

Merged
merged 12 commits into from
Feb 14, 2024
Merged

PyCode "Unparse": Added support for slice objects in subscriptions #11981

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
8372883
Add visit_Slice in pycode.ast.py
MatrixEditor Feb 14, 2024
06b10ad
Update CHANGES and add tests
MatrixEditor Feb 14, 2024
0f86d90
Merge branch 'master' into feature-ast-slice
MatrixEditor Feb 14, 2024
d9914d4
Fix slice "unparsing" behaviour
MatrixEditor Feb 14, 2024
4ca16f5
Moved visit_Slice to conform to alphabetic method order
MatrixEditor Feb 14, 2024
94d5a5a
Remove blank lines
MatrixEditor Feb 14, 2024
6c433b2
Merge branch 'master' into feature-ast-slice
MatrixEditor Feb 14, 2024
5e78978
Add numpy subscript syntax tests
MatrixEditor Feb 14, 2024
980afb8
Format code (add trailing comma)
MatrixEditor Feb 14, 2024
439c592
Update CHANGES.rst
MatrixEditor Feb 14, 2024
72af542
Add test for slicing notation in function arguments
MatrixEditor Feb 14, 2024
886b9b5
Fix broken tests
MatrixEditor Feb 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Format code (add trailing comma)
  • Loading branch information
@MatrixEditor
MatrixEditor committed Feb 14, 2024
commit 980afb8f642e778b5f84c2821ee9001495388030
2 changes: 1 addition & 1 deletion tests/test_pycode/test_pycode_ast.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@
("x[:, np.newaxis, :, :]",
"x[:, np.newaxis, :, :]"), # Index, Subscript, numpy extended syntax
("y[:, 1:3][np.array([0, 2, 4]), :]",
"y[:, 1:3][np.array([0, 2, 4]), :]") # Index, 2x Subscript, numpy extended syntax
"y[:, 1:3][np.array([0, 2, 4]), :]"), # Index, 2x Subscript, numpy extended syntax
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just by looking at all those identity checks, I think we should have used a sentinel value, say IDENTICAL, to indicate that the output is the same as the input. This is an easy follow-up PR though.

])
def test_unparse(source, expected):
module = ast.parse(source)
Expand Down