Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config: copyright correction logic: handle year-to-year ranges without trailing authorship info #11914

Merged

Conversation

jayaddison
Copy link
Contributor

Feature or Bugfix

  • Bugfix

Purpose

  • Allow concise, year-to-year copyright declarations such as 1970-1971 (with no trailing author name / info).

Detail

  • Use a string slice when performing a conditional check on trailing content, allowing an empty string to be returned instead of an array access error exception being raised.

Relates

@picnixz
Copy link
Member

picnixz commented Feb 24, 2024

I think we are good with this one right?

@jayaddison
Copy link
Contributor Author

I think we are good with this one right?

Good from my point-of-view (as author, admittedly). I'll open a separate ticket/discussion within a few days to ask about the (existing) ambiguity around year-only copyright entries.

@picnixz
Copy link
Member

picnixz commented Feb 24, 2024

Ok, then I think we can merge this one.

@picnixz picnixz merged commit 8aa5edd into sphinx-doc:master Feb 24, 2024
22 checks passed
@picnixz
Copy link
Member

picnixz commented Feb 24, 2024

Thank you

@jayaddison jayaddison deleted the issue-11913/copyright-correction-fixup branch February 24, 2024 16:32
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 27, 2024
@AA-Turner AA-Turner added this to the 7.3.0 milestone Jul 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

copyright accepts different values when SOURCE_DATE_EPOCH is/is not in the environment
3 participants