Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Africa/Cairo: wrong TZ offset #404

Closed
artask opened this issue Dec 5, 2023 · 3 comments
Closed

Africa/Cairo: wrong TZ offset #404

artask opened this issue Dec 5, 2023 · 3 comments
Labels
next-release

Comments

@artask
Copy link

artask commented Dec 5, 2023

In Africa/Cairo parsed dates return wrong timezone offset. The offset is +1 while in fact it should be +2.

On the screenshot below: logged JS Date followed by spacetime(date).format('iso')
image (1)

I see that in the previous patch release something similar has been fixed for Casablanca. I thought this may be related.

Thank you for the great package!
@spencermountain
Copy link
Owner

ah good catch! will add this to the next release.
ideally will be this week.
cheers

@finiteinfinity finiteinfinity mentioned this issue Dec 7, 2023
Open
spencermountain added a commit that referenced this issue Dec 11, 2023
@spencermountain
fix for cairo #404
8813dc8
@spencermountain spencermountain mentioned this issue Dec 11, 2023
Merged
@spencermountain
Copy link
Owner

fixed in 7.5.0 - thank you!

@artask
Copy link
Author

artask commented Dec 11, 2023

Amazing! Thanks for the quick fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
next-release
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@spencermountain @artask