This repository has been archived by the owner on Aug 28, 2021. It is now read-only.
Fix an issue with Attribute types. #97
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I don't fully understand this. There doesn't seem to be a `Type` property on [`System.Attribute`](https://docs.microsoft.com/en-us/dotnet/api/system.attribute?view=netframework-4.5), so I don't know why it generally works at the moment. Deserialisation didn't work on iOS when compiled through Unity's IL2CPP, but it does with this fix.
|
Yep, that file is a legacy from back in the days. It is magic, as it was originally autogenerated code from nswag based on the swagger specs. Of course, magic had to be tinkered with, so there is some hard-coded stuff that makes it even more brittle. In short, it just looks for the discriminator aptly named I'll test with Gh and the rest as soon as i get the chance... We'll probably need to look at this closely in the near future. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't fully understand this. There doesn't seem to be a
Typeproperty onSystem.Attribute, so I don't know why it generally works at the moment. Deserialisation didn't work on iOS when compiled through Unity's IL2CPP, but it does with this fix.I'm not set up to test this with the current Dynamo & Grasshopper builds, and that should probably happen before merging.
Generally, this file seems a bit magic & confusing. Feedback would be welcome.