This repository has been archived by the owner on Aug 28, 2021. It is now read-only.
Moved a call to get types for a referenced assembly into the SafeLoad… #148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…Assembly method.
I tried to remove a library from the Structural kit which no other plugin other than SpeckleGSA needs, which SpeckleGSA loads itself anyway - but found that because SpeckleRevit loads all assemblies and tries to get all types in all assemblies, a missing reference causes an uncaught exception to be thrown.
In a similar way to how SpeckleCore swallows exceptions related to the API/SDK libraries of specific applications not being present, I'd like it to ignore any issues with getting types from assemblies.