Skip to content
This repository has been archived by the owner on Aug 28, 2021. It is now read-only.

Avoid index out of bounds error when deserialising empty lists. #127

Merged
merged 1 commit into from
Jul 4, 2019
Merged

Avoid index out of bounds error when deserialising empty lists. #127

merged 1 commit into from
Jul 4, 2019

Conversation

se-li
Copy link
Collaborator

@se-li se-li commented Jul 4, 2019

Added checks to avoid throwing exceptions when trying to access items in zero-length lists

@se-li se-li requested a review from didimitrie July 4, 2019 12:45
@didimitrie
Copy link
Member

looks good, thanks for spotting this! I'll merge away.

@didimitrie didimitrie merged commit d5b033e into master Jul 4, 2019
didimitrie
didimitrie reviewed Jul 4, 2019
View reviewed changes
Copy link
Member

@didimitrie didimitrie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all ok :)

@se-li
Copy link
Collaborator Author

se-li commented Jul 4, 2019

Oh you were quick :) Cheers!

@se-li se-li deleted the se-li/deserialisation-fix branch July 4, 2019 12:52
@didimitrie
Copy link
Member

Heh, i try to be responsive - doesn't always play out like this though...

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@didimitrie didimitrie didimitrie left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@se-li @didimitrie @sebastianlindholm