WEB-1053 Create helpers for testing automate functions #339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #339 +/- ##
==========================================
+ Coverage 87.58% 87.76% +0.18%
==========================================
Files 95 95
Lines 5646 5648 +2
==========================================
+ Hits 4945 4957 +12
+ Misses 701 691 -10 ☔ View full report in Codecov by Sentry. |
gjedlicska
approved these changes
Jun 6, 2024
src/speckle_automate/helpers.py
Outdated
| def get_test_automation_environment() -> TestAutomationEnvironment: | ||
| """Get known environment variables from local `.env` file""" | ||
|
|
||
| return TestAutomationEnvironment().model_dump() |
There was a problem hiding this comment.
This should return the instance, not the json dump
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The process for testing a function in an automation has changed recently and we're updating the SDKs to reflect the new process.
I think special attention to the pydantic usage is a good idea. This works! But I don't have enough time with it to say this is the best or most python-y way to accomplish what it's trying to do.