Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(automate): make sure we exit with code 0 if execution completes #338

Merged
merged 2 commits into from
Jun 3, 2024

Conversation

gjedlicska
Copy link
Collaborator

Description & motivation

Changes:

To-do before merge:

Screenshots:

Validation of changes:

Checklist:

  • My pull request follows the guidelines in the Contributing guide?
  • My pull request does not duplicate any other open Pull Requests for the same update/change?
  • My commits are related to the pull request and do not amend unrelated code or documentation.
  • My code follows a similar style to existing code.
  • I have added appropriate tests.
  • I have updated or added relevant documentation.

References

@gjedlicska gjedlicska requested a review from cdriesler June 3, 2024 12:38
Copy link

codecov bot commented Jun 3, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 87.58%. Comparing base (204aa74) to head (239bc4b).

Files Patch % Lines
src/speckle_automate/runner.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #338      +/-   ##
==========================================
+ Coverage   87.56%   87.58%   +0.01%     
==========================================
  Files          95       95              
  Lines        5647     5646       -1     
==========================================
  Hits         4945     4945              
+ Misses        702      701       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gjedlicska gjedlicska merged commit e6b822b into main Jun 3, 2024
4 of 5 checks passed
@gjedlicska gjedlicska deleted the gergo/automateExitCode branch June 3, 2024 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants