Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: adds connection_timeout argument to SpeckleClient #337

Merged

Conversation

Aleksei-Willow
Copy link
Contributor

Description & motivation

Fixes #336

Changes:

Expose the timeout argument from the underlying RequestsHTTPTransport to SpeckleClient

To-do before merge:

Screenshots:

Validation of changes:

Checklist:

  • My pull request follows the guidelines in the Contributing guide?
  • My pull request does not duplicate any other open Pull Requests for the same update/change?
  • My commits are related to the pull request and do not amend unrelated code or documentation.
  • My code follows a similar style to existing code.
  • I have added appropriate tests.
  • I have updated or added relevant documentation.

References

Copy link

codecov bot commented May 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.56%. Comparing base (24019e9) to head (a7aff31).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #337   +/-   ##
=======================================
  Coverage   87.56%   87.56%           
=======================================
  Files          95       95           
  Lines        5645     5647    +2     
=======================================
+ Hits         4943     4945    +2     
  Misses        702      702           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JR-Morgan JR-Morgan self-requested a review May 27, 2024 13:19
Copy link
Member

@JR-Morgan JR-Morgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JR-Morgan JR-Morgan merged commit 204aa74 into specklesystems:main May 27, 2024
5 checks passed
@JR-Morgan
Copy link
Member

Thanks @Aleksei-Willow for your contribution, this change is now Live on SpecklePy 2.19.1 https://pypi.org/project/specklepy/

@JR-Morgan JR-Morgan added this to the 2.19 milestone May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhancement: allow setting connection timeout for SpeckleClient
3 participants