Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework automate SDK for the integrated automate api #335

Merged
merged 3 commits into from
May 16, 2024

Conversation

gjedlicska
Copy link
Collaborator

No description provided.

@gjedlicska gjedlicska requested a review from cdriesler May 16, 2024 15:20
Copy link

codecov bot commented May 16, 2024

Codecov Report

Attention: Patch coverage is 69.23077% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 87.56%. Comparing base (6469b6f) to head (64492fa).

Files Patch % Lines
src/speckle_automate/automation_context.py 11.11% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #335      +/-   ##
==========================================
- Coverage   90.32%   87.56%   -2.77%     
==========================================
  Files          95       95              
  Lines        5633     5645      +12     
==========================================
- Hits         5088     4943     -145     
- Misses        545      702     +157     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@cdriesler cdriesler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one minor note about comments/types

def get(self, stream_id: str, name: str, commits_limit: int = 10):
def get(
self, stream_id: str, name: str, commits_limit: int = 10
) -> Union[Branch, None, SpeckleException]:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

low importance, but docstring does not match type hint anymore

@gjedlicska gjedlicska merged commit 24019e9 into main May 16, 2024
3 of 5 checks passed
@gjedlicska gjedlicska deleted the gergo/automateInterfaceRework branch May 16, 2024 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants