Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): [CNX-9108] Added server migration support #331

Conversation

JR-Morgan
Copy link
Member

@JR-Morgan JR-Morgan commented Mar 15, 2024

Added server migration properties to server info
Added new function in Credentials.py get_account_for_server(host: str)
Added unit test (mimicking the C# one) to test above function

Equivalent to the specklesystems/speckle-sharp#3201 and specklesystems/speckle-sharp#3216

@JR-Morgan JR-Morgan force-pushed the CNX-9108-Python-JS-Update-serverInfo-return-type-and-queries-to-include-new-migration-property branch from 7df306a to ace6722 Compare March 15, 2024 16:57
Copy link

codecov bot commented Mar 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.32%. Comparing base (1b59f0b) to head (66dc076).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #331      +/-   ##
==========================================
+ Coverage   90.22%   90.32%   +0.09%     
==========================================
  Files          94       95       +1     
  Lines        5578     5633      +55     
==========================================
+ Hits         5033     5088      +55     
  Misses        545      545              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JR-Morgan JR-Morgan merged commit 6da5da2 into main Mar 25, 2024
5 checks passed
@JR-Morgan JR-Morgan deleted the CNX-9108-Python-JS-Update-serverInfo-return-type-and-queries-to-include-new-migration-property branch March 25, 2024 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants