Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(objects): [CNX-9014] Fixed issue with Spiral turns not deserializing in SpecklePy #329

Merged
merged 1 commit into from
Feb 19, 2024

Conversation

JR-Morgan
Copy link
Member

@JR-Morgan JR-Morgan commented Feb 19, 2024

See https://spockle.atlassian.net/browse/CNX-9014

This PR may also address #301 , once released we should ping them

Copy link

codecov bot commented Feb 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e726345) 90.21% compared to head (dbc1aef) 90.21%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #329   +/-   ##
=======================================
  Coverage   90.21%   90.21%           
=======================================
  Files          94       94           
  Lines        5579     5579           
=======================================
  Hits         5033     5033           
  Misses        546      546           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JR-Morgan JR-Morgan merged commit 7812393 into main Feb 19, 2024
5 checks passed
@JR-Morgan JR-Morgan deleted the jrm/spirals-fix branch February 19, 2024 13:05
@JR-Morgan JR-Morgan added this to the 2.18 milestone Feb 26, 2024
@JR-Morgan JR-Morgan linked an issue Feb 26, 2024 that may be closed by this pull request
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SpeckleException: Cannot set 'Spiral.turns'
2 participants