Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add to_string; add cases for object url in fe2 #327

Merged
merged 8 commits into from
Feb 9, 2024

Conversation

KatKatKateryna
Copy link
Contributor

Description & motivation

Changes:

To-do before merge:

Screenshots:

Validation of changes:

Checklist:

  • My pull request follows the guidelines in the Contributing guide?
  • My pull request does not duplicate any other open Pull Requests for the same update/change?
  • My commits are related to the pull request and do not amend unrelated code or documentation.
  • My code follows a similar style to existing code.
  • I have added appropriate tests.
  • I have updated or added relevant documentation.

References

Copy link

codecov bot commented Feb 5, 2024

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (6d7e7c5) 90.20% compared to head (2a675c8) 90.27%.
Report is 4 commits behind head on main.

Files Patch % Lines
tests/intergration/test_wrapper.py 88.88% 4 Missing ⚠️
src/specklepy/core/api/wrapper.py 95.45% 3 Missing ⚠️
src/specklepy/core/api/resources/server.py 87.50% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #327      +/-   ##
==========================================
+ Coverage   90.20%   90.27%   +0.07%     
==========================================
  Files          89       89              
  Lines        5351     5442      +91     
==========================================
+ Hits         4827     4913      +86     
- Misses        524      529       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@AlanRynne AlanRynne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We must have a chat about this implementation. On the surface it looks correct but it is vastly different both in logic and in structure to what we have in C#.

Ideally we'd want these classes to be mirrored so that the same (or similar) methods can be found in both, with similar return types and logic.

@gjedlicska
Copy link
Collaborator

gjedlicska commented Feb 7, 2024

What can I add to this discussion? Other than sanity check, i do not have much.

Copy link
Member

@AlanRynne AlanRynne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! Thx for the extra unit test 🙇🏼‍♂️🙌🏼🥳

@AlanRynne AlanRynne merged commit a0ca10a into main Feb 9, 2024
5 checks passed
@AlanRynne AlanRynne deleted the stream_wrapper_to_string branch February 9, 2024 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants