.url attribute was used before assignment; assign account to unauthen… #322
Conversation
…ticated client to get token
| ) | ||
| ) | ||
| self.account = get_default_account() |
There was a problem hiding this comment.
what is the reason for providing a fallback to the default account?
I'm not very much in favor of this, it gives more uncertainty into which account you are actually using, to send stuff. I'd much rather fail with an error, if the transport gets an invalid account.
There was a problem hiding this comment.
In case the ServerTransport is initiated via non-authenticated client (e.g. from Stream Wrapper of a public stream), the the self.account will stay None, and self.session.headers (line 101 in an updated code) will fail ("None has no attribute token"). And the user should be able to receive a public stream from any account
There was a problem hiding this comment.
That is a StreamWrapper implementation issue, that we should fix there. Also the type of account is an Optional[Account], so we should do a None check on line 101 and only add an authorization header if we have an actual account.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #322 +/- ##
=======================================
Coverage 90.25% 90.25%
=======================================
Files 89 89
Lines 5447 5448 +1
=======================================
+ Hits 4916 4917 +1
Misses 531 531 ☔ View full report in Codecov by Sentry. |
…ticated client to get token
Description & motivation
Changes:
To-do before merge:
Screenshots:
Validation of changes:
Checklist:
References