Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for Blocks and Asset saving #80

Merged
merged 11 commits into from
Oct 27, 2022
Merged

Added support for Blocks and Asset saving #80

merged 11 commits into from
Oct 27, 2022

Conversation

JR-Morgan
Copy link
Member

@JR-Morgan JR-Morgan commented Oct 13, 2022

Added support for Blocks

  • Blocks will now receive with correct nesting, and correct transforms

Refactored the way we save native objects as assets. This has be abstracted into several classes inheriting AbstractNativeCache

TODO before merge

  • Bug with prefabs instantiated with invalid meshes
  • Issue with meshes with no material, defaulting back to unity's non material (magenta)
  • Document these features/changes

@JR-Morgan JR-Morgan marked this pull request as ready for review October 21, 2022 20:15
@JR-Morgan JR-Morgan mentioned this pull request Oct 21, 2022
@JR-Morgan JR-Morgan removed a link to an issue Oct 21, 2022
@JR-Morgan JR-Morgan merged commit f4aba6c into main Oct 27, 2022
@JR-Morgan JR-Morgan deleted the jrm/blocks branch October 27, 2022 13:27
@JR-Morgan JR-Morgan linked an issue Oct 27, 2022 that may be closed by this pull request
@JR-Morgan JR-Morgan linked an issue Oct 27, 2022 that may be closed by this pull request
@JR-Morgan JR-Morgan mentioned this pull request Oct 27, 2022
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants