Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: simple serializable field for editor data #28

Closed
wants to merge 17 commits into from
Closed

feat: simple serializable field for editor data #28

wants to merge 17 commits into from

Conversation

haitheredavid
Copy link
Contributor

Added a couple of fields to the SpeckleProperties that will serialize the the object values passed in.
I think I still have some issues with the code style not lining up with yours @teocomi :|

teocomi and others added 12 commits June 29, 2021 20:27
re specklesystems/speckle-sharp#557 (not essential; default behaviour still
ok, but this is to keep things aligned)
one line change for showing user email and server instead of name
error from previous pull that didn't treat RecursiveConverter as a Monobehaviour
Example of implementations for serializing speckle properties data
@haitheredavid haitheredavid marked this pull request as ready for review July 9, 2021 19:09
@haitheredavid haitheredavid marked this pull request as draft July 9, 2021 19:11
@haitheredavid
Copy link
Contributor Author

I'll fix my code style so it doesn't push up so much poop with this PR before I take it out of draft

@teocomi teocomi self-requested a review July 13, 2021 15:22
@haitheredavid haitheredavid marked this pull request as ready for review July 13, 2021 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants