Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(server): adds content-security-policy header to server endpoints #2500

Merged
merged 9 commits into from
Jul 25, 2024
Merged

feat(server): adds content-security-policy header to server endpoints #2500

merged 9 commits into from
Jul 25, 2024

Conversation

iainsproat
Copy link
Contributor

@iainsproat iainsproat commented Jul 12, 2024 •
edited
Loading

Description & motivation

The lack of a content-security-policy header may allow a malicious actor to exploit a 'clickjacking' technique. This PR mitigates this risk for the endpoints served by the server.

https://linear.app/speckle/issue/WEB-1201/content-security-policy-header-not-provided-in-responses

Changes:

To-do before merge:

Screenshots:

Validation of changes:

Checklist:

  • My pull request follows the guidelines in the Contributing guide?
  • My pull request does not duplicate any other open Pull Requests for the same update/change?
  • My commits are related to the pull request and do not amend unrelated code or documentation.
  • My code follows a similar style to existing code.
  • I have added appropriate tests.
  • I have updated or added relevant documentation.

References

@iainsproat iainsproat changed the title feat(frontend 1): adds content-security-policy header to non-embeddab… feat(frontend 1): adds content-security-policy header to fe1 & server, including /graphql Jul 19, 2024
@iainsproat iainsproat marked this pull request as ready for review July 19, 2024 10:09
@iainsproat iainsproat marked this pull request as draft July 19, 2024 13:09
@iainsproat iainsproat changed the title feat(frontend 1): adds content-security-policy header to fe1 & server, including /graphql feat(server): adds content-security-policy header to server endpoints Jul 21, 2024
@iainsproat iainsproat marked this pull request as ready for review July 22, 2024 16:34
@iainsproat iainsproat merged commit eefeef1 into main Jul 25, 2024
21 of 23 checks passed
@iainsproat iainsproat deleted the iain/fe1-content-security-policy-header branch July 25, 2024 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabis94 fabis94 fabis94 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@iainsproat @fabis94