Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(metrics): add num pending validations to knex metrics #2444

Merged
merged 1 commit into from
Jun 27, 2024

Conversation

iainsproat
Copy link
Contributor

@iainsproat iainsproat commented Jun 26, 2024

Description & motivation

numPendingValidations is a metric exposed by the connection pool. The pending validation state is after the pending acquisition state, before the connection is moved to an 'in use' state.

This state needs to be included in calculations of remaining capacity of the pg connection pool

Changes:

To-do before merge:

Screenshots:

Validation of changes:

Checklist:

  • My pull request follows the guidelines in the Contributing guide?
  • My pull request does not duplicate any other open Pull Requests for the same update/change?
  • My commits are related to the pull request and do not amend unrelated code or documentation.
  • My code follows a similar style to existing code.
  • I have added appropriate tests.
  • I have updated or added relevant documentation.

References

@iainsproat iainsproat marked this pull request as ready for review June 26, 2024 20:47
@iainsproat iainsproat merged commit e55a940 into main Jun 27, 2024
21 of 23 checks passed
@iainsproat iainsproat deleted the iain/knex-num-pending-validations branch June 27, 2024 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants