Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: object-sender, allows empty strings and zeros props to be serialized #2426

Merged
merged 1 commit into from
Jun 24, 2024
Merged

fix: object-sender, allows empty strings and zeros props to be serialized #2426

merged 1 commit into from
Jun 24, 2024

Conversation

iltabe
Copy link
Contributor

@iltabe iltabe commented Jun 24, 2024 •
edited
Loading

Description & motivation

Fixes #2425

Changes:

To-do before merge:

Screenshots:

Validation of changes:

Checklist:

  • My pull request follows the guidelines in the Contributing guide?
  • My pull request does not duplicate any other open Pull Requests for the same update/change?
  • My commits are related to the pull request and do not amend unrelated code or documentation.
  • My code follows a similar style to existing code.
  • I have added appropriate tests.
  • I have updated or added relevant documentation.

References

@didimitrie didimitrie merged commit ae0eeba into specklesystems:main Jun 24, 2024
16 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@didimitrie didimitrie didimitrie approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: object-sender, it doesn't send empty strings or zeros
2 participants
@iltabe @didimitrie