Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(fe2): View menu not outputting correct names #2298

Conversation

andrewwallacespeckle
Copy link
Contributor

@andrewwallacespeckle andrewwallacespeckle commented May 29, 2024

Description & motivation

It was reported by Nikos that Views were not named correctly in the View menu. They were outputing the ID of the view, rather than the name.

We were outputting view.name which should have been view.view.name.

I have tested this with a Rhino model, and a Revit model.

Changes:

  • Change view.name to view.view.name to match the correct shape of views
  • Stop close on selection. Had to remove headlessui

Copy link

linear bot commented May 29, 2024

@andrewwallacespeckle andrewwallacespeckle marked this pull request as ready for review May 29, 2024 12:22
packages/viewer/src/IViewer.ts Outdated Show resolved Hide resolved
@AlexandruPopovici
Copy link
Contributor

@andrewwallacespeckle
I've changed the SpeckleView model so that there is no more unneeded legacy stuff. I've updated the viewer library to use the new model, but I haven't done so to the frontend, that's why the CI is failing.

@andrewwallacespeckle
Copy link
Contributor Author

@andrewwallacespeckle I've changed the SpeckleView model so that there is no more unneeded legacy stuff. I've updated the viewer library to use the new model, but I haven't done so to the frontend, that's why the CI is failing.

I can sort the frontend, thanks for checking this for me, Alex!

@andrewwallacespeckle andrewwallacespeckle merged commit d8d1173 into main Jun 3, 2024
20 of 22 checks passed
@andrewwallacespeckle andrewwallacespeckle deleted the andrew/web-989-use-name-instead-of-id-for-saved-views branch June 3, 2024 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants