-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: ensure consistent ordering of nodes to match ViewerLayoutPanel #2279
feat: ensure consistent ordering of nodes to match ViewerLayoutPanel #2279
Conversation
@andrewwallacespeckle I don't completely understand this sorting: "Model w/ version > Model > Folder name > Object ID". Can you explain? |
I'm not entirely sure why this was order was chosen, but it is very intentional. There is even a comment about it:
We can easily update this, but I'd assume that order was chosen for a reason. This PR uses the same ordering method in Scene Explorer to replicate Models order. |
Latest changes made on pairing call with @fabis94 |
Description & motivation
Currently, in the viewer, the Model panel has a different ordering to the Scene Explorer. This task aims to correct this by ordering Scene Explorer as Model panel currently is:
Model w/ version > Model > Folder name > Object ID
Changes
Correctly classify and order nodes into versionNodes, modelNodes, folderNodes, allModelNodes, and objectNodes