feat(fe1): WEB-734 - dissuade fe1 signups #2237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabis94
approved these changes
May 2, 2024
I can't get the local email server working, so invites don't work for me. I haven't had time to troubleshoot it properly, will hopefully get a look next week. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description & motivation
Linear Ticket
We were still getting a lot of fe1 signups, so it was decided to disable this when the env for fe2messaging is true.
Now, when you go to the login page, and click register, you will be redirected to the new register page.
If you go directly to the register page, you will be redirected to the new login page.
Also, the login blurb messaging is now based on the env, rather than always showing.
To do before merge:
@fabis94 Could you check over the registration token changes here? Just to make sure that this won't break the registration flow when a token is present, it should pass through to the new FE, but just checking this is the same in FE1 and FE2 and I am passing it correctly. This was hard to test.