Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(monitoring service): use structlog to seq #1957

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

iainsproat
Copy link
Contributor

Description & motivation

Log messages for monitoring service were not created in CLEF format using message template.

Screenshot 2024-01-11 at 12 53 32

Changes:

Add structlog_to_seq when logging.

To-do before merge:

Screenshots:

Validation of changes:

Checklist:

  • My pull request follows the guidelines in the Contributing guide?
  • My pull request does not duplicate any other open Pull Requests for the same update/change?
  • My commits are related to the pull request and do not amend unrelated code or documentation.
  • My code follows a similar style to existing code.
  • I have added appropriate tests.
  • I have updated or added relevant documentation.

References

@iainsproat iainsproat marked this pull request as ready for review January 11, 2024 14:36
@@ -15,6 +16,7 @@
structlog.stdlib.filter_by_level,
structlog.contextvars.merge_contextvars,
structlog.processors.add_log_level,
CelfProcessor(),
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gjedlicska - is this sufficient? Do we need to amend the other processors?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant