feat (MULTIPLE-MIGRATION-PATHS) #90: extend functionality to add real support for multiple migration paths #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rubenvanassche
requested changes
Oct 14, 2021
| @@ -64,7 +64,7 @@ public function register(): void | |||
|
|
|||
| private function removeMigrationsWhenSchemaLoaded(SchemaLoaded $event) | |||
| { | |||
| $migrations = collect(app(Filesystem::class)->files(config('settings.migrations_path'))) | |||
| $migrations = collect(app(Filesystem::class)->files(config('settings.migrations_paths'))) | |||
There was a problem hiding this comment.
We're providing an array to a string only function, this isn't going to work. Could you wrap this in another loop with the same feedback to the previous config key as before?
There was a problem hiding this comment.
No, this is not true. The phpDoc of Filesystem::files says it's string, but there is no type hint. The "$directory" is then passed to the Finder::in method which accepts "string|string[]" and casts the passed "$dirs" variable to an array. Therefore I would not change that.
…d real support for multiple migration paths
renepardon
force-pushed
the
multiple_migration_paths
branch
from
2a2f498
to
767628f
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request for discussion #90