Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Laravel Mix 6 support #90

Merged
merged 8 commits into from
Dec 21, 2020
Merged

Laravel Mix 6 support #90

merged 8 commits into from
Dec 21, 2020

Conversation

sebastiandedeyne
Copy link
Member

This branch correctly compiles the test stylesheet, but there are a few more (I believe upstream) issues that need to be resolved before this is stable.

  • Webpack throws an error that postcss-loader is missing, despite it being installed and available in node_modules. Adding postcss-loader as an explicit dependency solves the issue
  • Some plugins require Postcss 7, others 8. These are generally compatible with each other, so it's just the upstream packages that need to change their required Postcss versions to 8. This can be solved if you're using yarn by adding a resolutions entry in your package.json.

Once the stylesheets builds without these workarounds, this can be merged. Either way, I'm waiting on a stable Laravel Mix 6 release to tag this one.

@adamwathan
Copy link

Fix is to install postcss in the example, you need to manually install postcss most of the time now as PostCSS 8 is meant to be used as a peerDependency 👍

From postcss-loader docs:

image

@thecrypticace
Copy link

The latest Laravel Mix v6 beta now installs PostCSS 8 if it's not installed in the root package.json file. The postcss-loader error also disappeared after moving PostCSS to a peer dependency in Mix.

@sebastiandedeyne sebastiandedeyne marked this pull request as ready for review December 21, 2020 10:40
@sebastiandedeyne sebastiandedeyne merged commit 70b7ca7 into master Dec 21, 2020
@sebastiandedeyne
Copy link
Member Author

Released!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants