Update to latest version of purgecss plugin #48
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I am trying to get this issue pulled into my project so would like to update the purgecss plugin version: FullHuman/purgecss#92
|
Tests seem to be failing for this one. |
|
@freekmurze - unfortunately, the tests are also failing on master. I tried to fix, but can't seem to figure it out. Seems to be something with Jest. I updated the version of Jest to fix one issue (jestjs/jest#6766 (comment)), but that introduced another issue. Sorry I couldn't help try to fix it. Couldn't seem to figure it out on my end :( |
|
No worries, we'll take a look at this soon. |
|
I'll look into this soon. Gonna hold off merging a major version update of Purgecss until we've ensured it all works as intended. |
|
Ended up merging #49 for this because it solved the test issues, thanks for your time either way! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am trying to get this issue pulled into my project so would like to update the purgecss plugin version: FullHuman/purgecss#92