Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update purgecss #31

Merged
merged 2 commits into from
May 24, 2018
Merged

Update purgecss #31

merged 2 commits into from
May 24, 2018

Conversation

Ffloriel
Copy link
Contributor

Little PR to update to the latest version of purgecss-webpack-plugin compatible with webpack 3.

What would you want me to do with the package-lock.json? I'm usually creating the file .npmrc with package-lock=false but I know people have their own preferences when it comes to handling it.

And thank you for creating the package, it really helps the community use purgecss :)

- update to last version of webpack 3 purgecss
- npm run example
@sebastiandedeyne sebastiandedeyne merged commit e8e18bd into spatie:master May 24, 2018
@sebastiandedeyne
Copy link
Member

Perfect as is, thanks!

@sebastiandedeyne
Copy link
Member

I assume you meant yarn-lock, that one can stay since it's part of the example.

If you meant package-lock, afaik that doesn't really affect libraries?

@Ffloriel
Copy link
Contributor Author

I meant package-lock. Yes, it does not affect libraries so some repo add it to the .gitignore or add npmrc file not to generate package-lock. Or some just add the file anyway to the repo.
I just didn't commit the file to this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants