Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Purgecss version to allow support for whitelistPatternsChildren option #30

Merged
merged 1 commit into from
May 18, 2018

Conversation

aryehraber
Copy link
Contributor

This PR simply bumps the underlying purgecss-webpack-plugin version which brings support for a new whitelistPatternsChildren option.

@ankurk91
Copy link

ankurk91 commented May 16, 2018

The caret ^ sign in package.json means that you should be able to install 0.22.0 version.

@aryehraber
Copy link
Contributor Author

Yeah that's what I thought too, however it didn't seem to work; laravel-mix-purgecss would keep using v0.19.0 and thus whitelistPatternsChildren wouldn't be available to me in my Mix config.

@ankurk91
Copy link

Try reinstalling the package, it should pick latest dependencies.

@aryehraber
Copy link
Contributor Author

I did, a couple of times in fact because I was convinced it should automatically be pulling in the latest version of purgecss-webpack-plugin, but it would keep installing and using v0.19.0.

The only way I was able to resolve it locally was by cding into the package directly (inside node_modules) and run npm i [email protected].

Is it working for you as expected?

@sebastiandedeyne
Copy link
Member

The caret ^ sign in package.json means that you should be able to install 0.22.0 version.

No, there's a major version difference because it's still an 0. release.

I'll review and merge this tomorrow 👍

@aryehraber
Copy link
Contributor Author

A-ha! Didn't know that about 0. releases. Thanks @sebastiandedeyne!

@sebastiandedeyne sebastiandedeyne merged commit 2f6db87 into spatie:master May 18, 2018
@sebastiandedeyne
Copy link
Member

Released a patch version with this PR, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants