Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix OptimizerChainFactory's missing config processor #216

Merged
merged 3 commits into from
May 3, 2024

Conversation

0xb4lint
Copy link
Contributor

@0xb4lint 0xb4lint commented May 3, 2024

OptimizerChainFactory is not using the passed configuration (same issue in spatie/laravel-medialibrary#3566).

@0xb4lint 0xb4lint marked this pull request as draft May 3, 2024 13:17
@0xb4lint 0xb4lint changed the title WIP: fix OptimizerChainFactory's missing config processor Fix OptimizerChainFactory's missing config processor May 3, 2024
@0xb4lint 0xb4lint marked this pull request as ready for review May 3, 2024 13:29
@timvandijck
Copy link
Member

@0xb4lint looks good, thank you for the work!

@timvandijck timvandijck merged commit a639919 into spatie:main May 3, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants