Skip to content

Commit

Permalink
Don't mandate dl functions for the extention build
Browse files Browse the repository at this point in the history
Sqlite3-ruby doesn't use dl functions, nor does extconf compile sqlite3
sources, which possibly makes use of them.
So mandating dl functions in extconf is wrong and breaks the build on
Windows.

Fixes #250 .

This pertly reverts commit f4ffec2.
  • Loading branch information
larskanis committed Mar 9, 2019
1 parent 5c36dbe commit 9d9ed4b
Showing 1 changed file with 1 addition and 5 deletions.
6 changes: 1 addition & 5 deletions ext/sqlite3/extconf.rb
Original file line number Diff line number Diff line change
Expand Up @@ -64,11 +64,7 @@ def asplode missing
asplode('sqlite3.h') unless find_header 'sqlite3.h'
find_library 'pthread', 'pthread_create' # 1.8 support. *shrug*

have_library 'dl'

%w{ dlopen dlclose dlsym }.each do |func|
abort "missing function #{func}" unless have_func(func)
end
have_library 'dl' # for static builds

if with_config('sqlcipher')
asplode('sqlcipher') unless find_library 'sqlcipher', 'sqlite3_libversion_number'
Expand Down

0 comments on commit 9d9ed4b

Please sign in to comment.