Replace the default port with 8080 #352
Conversation
✅ Deploy Preview for robyn canceled.
|
OSX has some service running on port 5000 by default. It makes it annoying to work on Robyn to keep changing the default port number all the time.
b88c0d0 to
2416bab
Compare
|
Hey @AntoineRR , Can you have a look at this PR? |
There was a problem hiding this comment.
Hi @sansyrox !
This looks fine to me and runs well on my linux machine. I just noticed there are a few places where port 5001 was used in the tests. Do you want to keep it like this? Maybe we should replace it with 8081 for consistency?
| @@ -12,7 +12,7 @@ | |||
| # create robyn.env before test and delete it after test | |||
| @pytest.fixture | |||
| def env_file(): | |||
| CONTENT = """ROBYN_PORT=8080 | |||
| CONTENT = """ROBYN_PORT=8081 | |||
There was a problem hiding this comment.
@AntoineRR , as I wanted to test it on something other than the default port. Given that 8080 will be the default port from now on.
There was a problem hiding this comment.
I just noticed there are a few places where port 5001 was used in the tests. Do you want to keep it like this?
Sure, this sounds like a good idea. 😄
|
@AntoineRR , all done. 😄 |
robyn/robyn.pyi
Outdated
| @@ -21,6 +21,10 @@ class Response: | |||
| headers: dict[str, str] | |||
| body: str | |||
|
|
|||
| def set_file_path(file_path): | |||
There was a problem hiding this comment.
Can you add str typing to the parameter here?
There was a problem hiding this comment.
@AntoineRR , yep sure 👍
c487c1c to
d4b0c30
Compare
OSX has some service running on port 5000 by default. It makes it annoying to work on Robyn to keep changing the default port number all the time.
Description
This changes the default PORT of Robyn.